<Swing Dev> Replace concat String to append in StringBuilder parameters

Alan Bateman Alan.Bateman at oracle.com
Mon Aug 25 15:19:24 UTC 2014


On 25/08/2014 03:03, Wang Weijun wrote:
> New webrevs updated
>
> http://cr.openjdk.java.net/~weijun/8055723/core/webrev.00/
>
>    Includes modules java.base and security-related modules and the jarsigner tool
>
> http://cr.openjdk.java.net/~weijun/8055723/client/webrev.00
>
>    Includes the java.desktop module
>
> http://cr.openjdk.java.net/~weijun/8055723/extra/webrev.00
Thanks for donning the sponsor hat, it's always a pain to have deal with 
changes that require splitting between jdk9/dev and jdk9/client. 
Hopefully in time that this business can be re-visited so that changes 
to client libraries can be pushed to jdk9/dev. For the webrev then I 
assume there isn't any need to split core and what you call "extra" as 
they will all go into jdk9/dev.

I saw a few comments on tabs and maybe this is what I see but some of 
the indentation looks a bit odd and inconsistent in a number of places. 
It seems to be mostly places where method invocation chaining is used 
and the statement goes into a second or third line. In a few places then 
the .append is aligned with the start of sb.append (see DHParameters and 
GSMParameters for example), in other places then the second/more lines 
are pushed in by 8.

You can probably drop 
src/demo/share/jpda/com/sun/tools/example/debug/gui/ContextManager.java 
from the list as there is a patch in review on serviceability-dev that 
will get this of this obsolete demo.

-Alan.


More information about the security-dev mailing list