[9] RFR: 8054380: X.509 cert extension SubjectAltName should allow digits as first character of dNSName

Sean Mullan sean.mullan at oracle.com
Mon Aug 25 20:14:45 UTC 2014


On 08/25/2014 04:05 PM, Jason Uh wrote:
>
>
> On 08/25/2014 03:41 PM, Sean Mullan wrote:
>> Just a couple of comments:
>>
>> 1. I think the check on lines 106-110 can be done prior to the for loop
>> on line 94
>
> I think that check is actually where it should be because the for loop
> on line 94 loops over each component (while the inner loop on line 115
> checks the characters of that component). The check for the first and
> last characters is done just once per component.

Right, never mind. There is some extra indentation on line 95 where it 
isn't aligned properly - can you remove the extra spaces?

--Sean



More information about the security-dev mailing list