Please review CR8048819 Implement reliability test for DH algorithm
Valerie Peng
valerie.peng at oracle.com
Wed Dec 10 00:41:09 UTC 2014
Looks fine.
Thanks,
Valerie
On 12/9/2014 3:02 PM, Amanda Jiang wrote:
> Hi Valerie,
>
> Thanks for your comments, the test case is updated by your
> suggestions, please check below webrev:
> http://cr.openjdk.java.net/~tyan/amandaj/8048819/webrev.01/
>
> Thanks,
> Amanda
>
> On 12/5/14 3:37 PM, Valerie Peng wrote:
>> Amanda,
>>
>> Since the test is under the path for SunJCE provider, can you please
>> add the "SunJCE" provider name when calling getInstance()? This would
>> means that you need to update the test to handle
>> NoSuchProviderException, etc. But should be minor changes.
>>
>> Thanks,
>> Valerie
>>
>> On 10/12/2014 5:29 PM, Amanda Jiang wrote:
>>> Hello,
>>>
>>> Please help to review the changeset below, the new test
>>> stressful verifies the assertion of "The secret keys generated by
>>> all involved parties should be the same" for javax.crypto.KeyAgreement.
>>>
>>> Bug - https://bugs.openjdk.java.net/browse/JDK-8048819
>>> Webrev -
>>> http://cr.openjdk.java.net/~tyan/amandaj/8048819/webrev.00/
>>>
>>> Thanks,
>>> Amanda
>
More information about the security-dev
mailing list