RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

Alan Bateman Alan.Bateman at oracle.com
Mon Dec 29 15:51:53 UTC 2014


On 29/12/2014 09:45, Peter Levart wrote:
>
> Thanks for looking at this, Alan.
>
> You're right about File.getCanonicalFile(). It already checks read 
> permission for a file. The additional explicit check is superfluous. I 
> have removed it.
>
> With explicit check I wanted the API to behave uniformly regardless of 
> whether the returned stream is opened by getInputStream() call or an 
> already opened stream is just returned. getCannonicalFile() already 
> takes care of it. Here's the updated webrev:
>
> http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/ 
>
Updated patch looks good to me.

-Alan.



More information about the security-dev mailing list