Fwd: [9] RFR 8028727: warnings from b116 for jdk.src.share.native.sun.security.ec: JNI pending exceptions

Alan Bateman Alan.Bateman at oracle.com
Tue Feb 4 08:39:51 PST 2014


On 04/02/2014 16:31, Vincent Ryan wrote:
> :
>
> Please review this patch for better handling of JNI pending exceptions
> in the ECC native code:
>
> Webrev:  http://cr.openjdk.java.net/~vinnie/8028727/webrev.00/
>
> The patch examines the return code from JNI calls to check whether an
> exception is already pending. If so then it cleans up and returns.
This looks to good, I just wonder about the calls GetByteArrayRegion as 
they can potentially fail with NULL/ArrayIndexOutOfBoundsException. It 
would be a bug if we pass indexes that are out of range but it might be 
worth checking those too.

-Alan


More information about the security-dev mailing list