Code Review Request: 7107611 sun.security.pkcs11.SessionManager is scalability blocker

[Valerie (Yu-Ching) Peng]

Well, there are some changes that look strange which I need more time to 
figure out.
For example, the purpose for the 2 new pkg private methods of poll(Pool) 
and release(Pool, Session) of the static class Pool.

Also, now that every P11Cipher "object" has its own session pool, will 
this have any impact on the overall memory usage.
If P11Cipher object is not re-used much and only have a short life span, 
what's the point of having a local session pool to re-use the sessions.

Thanks,
Valerie



On 02/03/14 10:24, Anthony Scarpino wrote:
> Hi,
>
> I'm requesting a review of these changes.  It is mostly from the patch 
> that Intel provided, but I have made some cosmetic changes.  The 
> changes significantly improve performance in multithreaded application 
> using pkcs11.
>
> http://cr.openjdk.java.net/~ascarpino/7107611/webrev.00/
>
> thanks
>
> Tony