RFR: 8034033: [parfait] JNI exception pending in share/native/sun/security/krb5/nativeccache.c

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Wed Feb 12 16:48:05 PST 2014


Max,

Changes look fine.
However, I noticed some calls which may throw exceptions but no check is 
added, e.g.

  593         (*env)->SetObjectArrayElement(env, address_list, index, address);


BTW, I noticed there are several existing calls to 
ExceptionOccurred(...) which can be replaced with ExceptionCheck(...) 
calls which won't create local references to the exception object.

Thanks,
Valerie

On 02/11/14 04:27, Wang Weijun wrote:
> Hi All
>
> I didn't attend the parfait day last week, but a new one is coming. Please review my fix at
>
>    http://cr.openjdk.java.net/~weijun/8034033/webrev.00/
>
> Thanks
> Max
>



More information about the security-dev mailing list