8034856/8034857: More gcc warnings

Alan Bateman Alan.Bateman at oracle.com
Thu Feb 13 13:18:03 UTC 2014


The number of native code warnings in the build is annoying so this is 
another drive-by fix that eliminates a few of them in the serviceability 
and security areas. The webrev with the changes is here:

http://cr.openjdk.java.net/~alanb/8034856+8034857/webrev/

In the pkcs11 code the issue is the function prototypes for the throwXXX 
functions aren't included. This is fixed by including pkcs11wrapper.h 
but that exposes another issue with the header file includes that needed 
to be fixed.

In JarFacade the issue is that it uses isspace but doesn't include the 
ctype.h

For LinuxOperatingSystem.c then there are 12 warnings related to fscanf 
usages where the format specifier is %lld and the code wants to read 
into a uint64_t. I've changed the format specifier to"%"SCNd64 so that 
it matches uint64_t and should be okay on both 32 and 64-bit.

Thanks,
Alan.



More information about the security-dev mailing list