Review Request for JDK-8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending

[Xuelei Fan]

On 2/19/2014 10:34 AM, Valerie (Yu-Ching) Peng wrote:
> 
> Hmm, good question.
> When I checked JNI spec, it turns out that it didn't list any JNI
> exception under JNIEnv->GetStringUTFChars(...).
> Since this JNI method
> Java_sun_security_smartcardio_PlatformPCSC_initialize(..) does not
> return any object, perhaps we should throw some exception here to
> indicate a failure despite that it's very unlikely to happen in reality.
> 
> I think either NullPointerException or IOException will do here. Do you
> have a preference?
I prefer NPE if jLibName cannot be null.

Xuelei

> Valerie
> 
> On 02/14/14 18:01, Xuelei Fan wrote:
>> Looks fine to me.
>>
>> Just want to make sure, no exception should be thrown if libName is
>> null, right?
>>
>>    92     if (libName == NULL) {
>>    93         return;
>>    94     }
>>
>> Xuelei
>>
>> On 2/14/2014 7:29 AM, Valerie (Yu-Ching) Peng wrote:
>>> Can someone please review the fixes which checks for pending exceptions
>>> in native code "pcsc_md.c"?
>>> The fix is trivial scope-wise.
>>>
>>> Webrev: http://cr.openjdk.java.net/~valeriep/8033571/webrev.00/
>>>
>>> Thanks,
>>> Valerie
>