RFR 8044085: Access ExtendedGSSContext.inquireSecContext() result through SASL
Sean Mullan
sean.mullan at oracle.com
Wed Jul 9 12:00:20 UTC 2014
On 07/09/2014 04:31 AM, Wang Weijun wrote:
>
> On Jul 8, 2014, at 2:00, Sean Mullan <sean.mullan at oracle.com> wrote:
>
>> Looks good, just one comment in GssKrb5Base - I would change
>> getNegotiatedProperty to call the superclass method first, and then
>> if that returns null, check for the gss inquiretype properties.
>> This way you don't check for IllegalStateExc twice, and it seems
>> cleaner to me.
>
> My understanding is that if getNegotiatedProperty() methods of both
> parent class and child class return non-null, then the value from the
> child class should shadow the one from the parent.
That behavior is unspecified as far as I can see. In any case, if you
choose that behavior, you could still call the superclass first and then
override if necessary.
--Sean
>
>>
>> Also, please add a release notes label so that this is documented
>> in the release notes, and open a separate docs bug to add a section
>> to the SASL Reference Guide to more fully describe these new
>> properties and how to use them.
>
> Sure.
>
> Thanks Max
>
>>> http://cr.openjdk.java.net/~weijun/8044085/webrev.00
>>>
>
More information about the security-dev
mailing list