RFR [8046343] (smartcardio) CardTerminal.connect('direct') does not work on MacOSX

[Valerie Peng]

Looks fine to me.
Thanks,
Valerie

On 7/16/2014 11:46 AM, Ivan Gerasimov wrote:
> Thanks everyone for the input!
>
> I've updated the webrev as suggested:
> http://cr.openjdk.java.net/~igerasim/8046343/1/webrev/
>
> I have also added a simple manual test, which should help SQE make 
> sure the bug is gone.
>
> Sincerely yours,
> Ivan
>
> On 16.07.2014 16:18, Sean Mullan wrote:
>> On 07/15/2014 10:44 PM, Mandy Chung wrote:
>>> But someone could modify the default permissions and take out the
>>> PropertyPermission for "os.name", right?
>>
>> True. I think it would be better to wrap it in a doPriv in that case.
>>
>> --Sean
>>
>>>
>>> Mandy
>>>
>>> On 7/15/2014 6:19 PM, Wang Weijun wrote:
>>>> There is no permission needed to get the "os.name" property. The
>>>> global jre/lib/security/java.policy file also granted all codes to get
>>>> that.
>>>>
>>>> --Max
>>>>
>>>> On Jul 15, 2014, at 23:27, Sean Mullan <sean.mullan at oracle.com> wrote:
>>>>
>>>>> 2. The code on lines 65-69 introduces an undesirable dependency on
>>>>> sun.security.action for the JDK 9 modularization work. Please replace
>>>>> this with a nested PrivilegedAction subclass, or a lambda expression
>>>>> instead:
>>>>>
>>>>> AccessController.doPrivileged((PrivilegedAction<String>) () ->
>>>>> System.getProperty("os.name"));
>>>
>>
>>
>