[9] RFR 8035166: Remove dependency on EC classes from pkcs11 provider

Valerie Peng valerie.peng at oracle.com
Mon Jul 21 22:06:19 UTC 2014


Yeah, I used "hg rename" to move the 3 files to their new location.
Is there other way that I should handle the move?
Valerie

On 7/21/2014 8:12 AM, Vincent Ryan wrote:
> Your fix looks good.
>
> BTW the Webrev doesn’t identify the 3 renamed files, did you use ‘hg rename’?
>
>
> On 18 Jul 2014, at 18:13, Valerie Peng<valerie.peng at oracle.com>  wrote:
>
>> Vinnie,
>>
>> Could you please help reviewing this change?
>>
>> My current approach is to minimize code changes/refactoring - move the ECParameters, NamedCurve, CurveDB classes to sun.security.util package and then change the depending classes to use sun.security.util.XXX rather than sun.security.ec.XXX.
>>
>> Besides moving the 3 classes, I also changed some methods to public to be accessible from sun.security.ec package.
>>
>> webrev: http://cr.openjdk.java.net/~valeriep/8035166/webrev.00/
>>
>> Thanks,
>> Valerie
>>



More information about the security-dev mailing list