[9] RFR 8035166: Remove dependency on EC classes from pkcs11 provider
Sean Mullan
sean.mullan at oracle.com
Tue Jul 22 13:44:55 UTC 2014
Looks good.
--Sean
On 07/21/2014 06:33 PM, Valerie Peng wrote:
> Done, webrev updated at
> http://cr.openjdk.java.net/~valeriep/8035166/webrev.01/
> Thanks,
> Valerie
>
> On 7/21/2014 11:18 AM, Sean Mullan wrote:
>> Can you also change the following comment in
>> sun/security/ssl/SupportedEllipticCurvesExtension.java:
>>
>> // See sun.security.ec.NamedCurve for the OIDs
>>
>> to
>>
>> // See sun.security.util.NamedCurve for the OIDs
>>
>> Rest looks good to me. Please add a noreg label though.
>>
>> --Sean
>>
>> On 07/18/2014 01:13 PM, Valerie Peng wrote:
>>> Vinnie,
>>>
>>> Could you please help reviewing this change?
>>>
>>> My current approach is to minimize code changes/refactoring - move the
>>> ECParameters, NamedCurve, CurveDB classes to sun.security.util package
>>> and then change the depending classes to use sun.security.util.XXX
>>> rather than sun.security.ec.XXX.
>>>
>>> Besides moving the 3 classes, I also changed some methods to public to
>>> be accessible from sun.security.ec package.
>>>
>>> webrev: http://cr.openjdk.java.net/~valeriep/8035166/webrev.00/
>>>
>>> Thanks,
>>> Valerie
>>>
More information about the security-dev
mailing list