Webrev request: JDK-8015081

Jamil Nimeh jamil.j.nimeh at oracle.com
Wed Jun 11 04:01:17 UTC 2014

Hi Max,

You're probably right about collectionNullClean/throw question. When I 
first wrote that method I wasn't sure I'd always throw NPE as a 
consequent of it returning false, but it ended up working out that way.

I'm already reworking a couple tests so I'll take a look at implementing 
those comments tonight and kick another review out. Thanks for the comments.


On 06/10/2014 07:24 PM, Wang Weijun wrote:
> Hi Jamil
> Sorry I've just read the webrev.
> If you always throw an NPE after a collectionNullClean() call, isn't it simpler to let the method throw the NPE?
> Also, Objects.requireNonNull(o, msg) can be used in those "if (o == null)" cases.
> Thanks
> Max
> On Jun 10, 2014, at 23:32, Sean Mullan <sean.mullan at oracle.com> wrote:
>> Looks good to me.
>> --Sean
>> On 06/06/2014 06:16 PM, Jamil Nimeh wrote:
>>> One more version of this webrev with minor comment changes:
>>> http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04
>>> Thanks,
>>> --Jamil

More information about the security-dev mailing list