Review Request for JDK-8033571: [parfait] warning from b128 for security/smartcardio/pcsc_md.c: JNI exception pending

Anthony Scarpino anthony.scarpino at oracle.com
Wed Mar 5 19:50:37 UTC 2014


On 02/13/2014 03:29 PM, Valerie (Yu-Ching) Peng wrote:
>
> Can someone please review the fixes which checks for pending exceptions
> in native code "pcsc_md.c"?
> The fix is trivial scope-wise.
>
> Webrev: http://cr.openjdk.java.net/~valeriep/8033571/webrev.00/
>
> Thanks,
> Valerie

In my change that's out for review, 8036543, I only checked for 
findFunction() returning null, while you used ExceptionCheck.  Was there 
something you saw that caused you to check for an exception thrown 
rather than null?

Either way the change looks good to me.

Tony




More information about the security-dev mailing list