Code review request: 8036543 Parfait JNI pending exceptions for j2secmod.c, j2secmod_md.c, and p11_md.c

[Valerie (Yu-Ching) Peng]

How about line 223, there may be a pending exception thrown as well and 
this is inside a loop?
Valerie

On 03/06/14 14:37, Anthony Scarpino wrote:
> webrev updated at:
>  http://cr.openjdk.java.net/~ascarpino/8036543/webrev.01/
>
> On 03/05/2014 04:02 PM, Anthony Scarpino wrote:
>> Sure.. I debated that piece of code before the review too.
>>
>> Tony
>>
>> On 03/05/2014 03:52 PM, Valerie (Yu-Ching) Peng wrote:
>>>
>>> <j2secmod.c>
>>> line 133 - 138, I think it's better to take the ReleaseStringUTFChars()
>>> call of 'configDir' out of the block for 'functionName'.
>>> So we can ensure that both are released even if the code from 82-94 are
>>> somehow later altered.
>>>
>>> The rest looks fine.
>>> Thanks,
>>> Valerie
>>>
>>> On 03/04/14 22:56, Anthony Scarpino wrote:
>>>> Hi,
>>>>
>>>> I need a review for changes that cover JNI pending exceptions for
>>>> j2secmod.c, j2secmod_md.c, and p11_md.c
>>>>
>>>> http://cr.openjdk.java.net/~ascarpino/8036543/webrev.00/
>>>>
>>>> thanks
>>>>
>>>> Tony
>>>
>>
>