Code review request 8037346, Need to terminate server process if client runs into problems

[Xuelei Fan]

On 3/17/2014 5:16 PM, Wang Weijun wrote:
> 
> On Mar 17, 2014, at 17:06, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
>> On 3/17/2014 4:59 PM, Wang Weijun wrote:
>>> What is the problem now? Test fails after 120 seconds of default timeout?
>>>
>> These test are for shell script tests.  The bug reported stated the
>> server did not terminated on Windows.  I think may be shell script test
>> is not controlled by the default timeout, or it get run manually.
> 
> I guess the tests are written in shell because of that $HOSTNAME? Is it possible to get that info inside Java?
> 
I did not dig it further.  Looks like it is possible.  I will not
address the improvement this time.

Xuelei

>>
>>> This SO_TIMEOUT could be useful to make sure a test fails early, but I am not sure if the value is big enough. If the failure is rare, I would choose 30 seconds.
>>>
>> 30 seconds is OK.
> 
> Good.
> 
> --Max
> 
>>
>> Xuelei
>>
>>> --Max
>>>
>>> On Mar 17, 2014, at 16:34, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> Please review this test fix:
>>>>
>>>> webrev: http://cr.openjdk.java.net/~xuelei/8037346/webrev.00/
>>>>
>>>> Tests fix. If client runs into problems, the server side may be blocked
>>>> on socket.accept().  This fix set SO_TIMEOUT to 5 seconds for each
>>>> server socket, so that if client runs into problems, the server will
>>>> terminate itself within 5 seconds.
>>>>
>>>> Thanks,
>>>> Xuelei
>>>
>>
>