RFR [8044342] build failure on Windows noticed with recent smartcardio fix.

Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Thu May 29 22:09:45 UTC 2014


Changes look good.
Thanks,
Valerie

On 05/29/14 13:39, Ivan Gerasimov wrote:
> Thanks Valerie!
>
> On 30.05.2014 0:09, Valerie (Yu-Ching) Peng wrote:
>>
>> 1) Since we are rolling back to the earlier code, how about just use 
>> the original code? I somehow find this easier to parse than the 2 
>> nested almost-identical for-loops in the current fix.
>>     char* cp = spec;
>>     while (*cp != 0) {
>>         cp += (strlen(cp) + 1);
>>         ++cnt;
>>     }
>>
>> 2) Add back the NULL check for the malloc call, e.g.
>>     if (tab == NULL) {
>>         throwOutOfMemoryError(env, NULL);
>>         return NULL;
>>     }
>>
> Alright, I reverted it back:
>
> http://cr.openjdk.java.net/~igerasim/8044342/1/webrev/
>
> It may be worth to return to this code later, since 
> pcsc_multi2jstring() had been seen in the stack traces of some crash 
> reports.
> But at the moment, reverting to the original code may be the easiest 
> way to restore build-ability.
>
> Sincerely yours,
> Ivan
>
>> Thanks,
>> Valerie
>>
>>
>> On 05/29/14 11:28, Ivan Gerasimov wrote:
>>> Hi!
>>>
>>> With the recent code modification I used a pcsc-lite specific 
>>> constant which is only defined on *nix platforms.
>>> As a result, windows builds failed. Sorry about that!
>>>
>>> Would you please review the partial backout fix: Dynamic array 
>>> allocation is restored.
>>>
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8044342
>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8044342/0/webrev/
>>>
>>> Sincerely yours,
>>> Ivan
>>
>>
>>
>



More information about the security-dev mailing list