Code Review Request: 8063700 -Xcheck:jni changes cause many JCK failures in api/javax_crypto tests with SunPKCS11

Sean Mullan sean.mullan at oracle.com
Fri Nov 7 12:44:52 UTC 2014


On 11/06/2014 07:06 PM, Anthony Scarpino wrote:
> It's completely dependent on Xcheck:jni.  I figured that was an option
> part of the testing process.  Not something that one put into a test. Is
> that wrong?

You could put it as an option in the @run tag, ex:

@run main/othervm -Xcheck:jni ...

There are a handful of tests that do that. Is there an existing test you 
could add that run tag to to reproduce the issue?

--Sean

>
> Tony
>
> On 11/06/2014 02:37 PM, Sean Mullan wrote:
>> It looks ok to me although I think Valerie should also review it. Is it
>> possible to add a simple regression test for this and not be dependent
>> on the JCK tests?
>>
>> --Sean
>>
>> On 11/06/2014 05:14 PM, Anthony Scarpino wrote:
>>> Hi,
>>>
>>> I need a review of this change to the pkcs11 wrapper code.  The changes
>>> allow encryption to work properly when -Xcheck:jni is called.   A recent
>>> change to -Xcheck:jni caused the failures to occur.
>>>
>>> http://cr.openjdk.java.net/~ascarpino/8063700/webrev/
>>>
>>> thanks
>>>
>>> Tony
>


More information about the security-dev mailing list