JDK 9 Review Request for 8046949: Generify the javax.xml.crypto API

Xuelei Fan xuelei.fan at oracle.com
Tue Nov 11 03:33:16 UTC 2014


Looks fine to me.

A pretty minor comment.

share/classes/javax/xml/crypto/dsig/spec/XPathType.java
-----------------------
 157         this.expression = expression;
 158         this.filter = filter;
 159         if (namespaceMap == null) {
 160             throw new NullPointerException("namespaceMap cannot be
null");
 161         }

I would like to check "namespaceMap == null" before the assignment of
this.expression and this.filter.

Thanks,
Xuelei

On 10/31/2014 9:30 PM, Sean Mullan wrote:
> Earlier this year, we dropped the requirement to deliver JSR 105 (XML
> Digital Signature API) as a standalone JSR [1], which will make it
> easier to add some long-standing enhancements to the API.
> 
> The first of those is to finally add support for generics to the API:
> 
> - all Collection and Iterator parameters and return types have been
> changed to parameterized types
> - javax.xml.crypto.NodeSetData has been changed to a generic class and
> also now implements Iterable so that it can be used in for-each loops
> - many SuppressWarnings annotations have been removed as they are no
> longer applicable
> 
> Issue: https://bugs.openjdk.java.net/browse/JDK-8046949
> webrev: http://cr.openjdk.java.net/~mullan/webrevs/8046949/webrev.00/
> 
> --Sean
> 
> [1] https://jcp.org/en/jsr/proposalDetails?id=105



More information about the security-dev mailing list