RFR 8061253: CCC 8043071 doesn't fully approve the change in JDK9b25

Sean Mullan sean.mullan at oracle.com
Wed Nov 19 14:10:13 UTC 2014


On 11/18/2014 02:47 AM, Wang Weijun wrote:
> Re-request for code review at
>
> http://cr.openjdk.java.net/~weijun/8061253/webrev.01/

* Principal:

This should also be included in the @implSpec, is it? You might need 
another implSpec tag before this, or remove the <p> as it isn't really 
necessary.

<p>Subclasses may override this with a different implementation, if
necessary.

* General

Sometimes you say "the Foo" and other times you say "this Foo". I think 
you should try to be consistent. I prefer "this Foo".

--Sean

>
> Most are still spec changes, with only one code change in
> KerberosTicket.java where KerberosPrincipal.toString() is changed to
> KerberosPrincipal.getName(). This is also because the spec for
> getName() is more suitable in this call.
>
> *Jamil*: I usually don't touch copyright years and let RE handle it.
> You might say this is not a good habit.
>
> Thanks Max
>
>> On Nov 15, 2014, at 08:05, Wang Weijun <weijun.wang at oracle.com>
>> wrote:
>>
>> Webrev withdrawn. I'd like to make more changes.
>>
>> Thanks Max
>>
>>> On Nov 14, 2014, at 10:38, Wang Weijun <weijun.wang at oracle.com>
>>> wrote:
>>>
>>> Hi All
>>>
>>> This is a doc change only bug. Fix at
>>>
>>> http://cr.openjdk.java.net/~weijun/8061253/webrev.00/
>>>
>>> Please take a review.
>>>
>>> Thanks Max
>>>
>>
>


More information about the security-dev mailing list