request for review : 8052406: SSLv2Hello protocol may be filtered out unexpectedly

Xuelei Fan xuelei.fan at oracle.com
Wed Oct 8 08:32:28 UTC 2014


Looks fine to me.  Thanks for take care of the backport.

Xuelei

On 10/8/2014 4:25 PM, Seán Coffey wrote:
> Ping.
> 
> regards,
> Sean.
> 
> On 02/10/2014 10:19, Seán Coffey wrote:
>> I should have prefixed my comments with point that this is a request
>> for review given the changes. Subject updated.
>>
>> regards,
>> Sean.
>>
>> On 01/10/2014 17:23, Seán Coffey wrote:
>>> Turned out that I do need to make a change to this backport. The
>>> testcase hadn't run initially on JPRT due to a new path in the test
>>> directories. I've fixed that now. The testcase needs tweaking for 7u.
>>>
>>> For 7u, the TLS_RSA_WITH_AES_128_CBC_SHA256 ciphersuite is not
>>> enabled by default in ClientHello. A minor change to the testcase on
>>> client socket can change that.
>>>
>>>>  137         String[] ciphers = sslSocket.getSupportedCipherSuites();
>>>>  138         sslSocket.setEnabledCipherSuites(ciphers);
>>>
>>> Rest of testcase stays the same as jdk8u.
>>> webrev : http://cr.openjdk.java.net/~coffeys/webrev.8052406.7u/webrev/
>>>
>>> regards,
>>> Sean.
>>>
>>>
>>>
>>> -------- Forwarded Message --------
>>> Subject: 	Re: [7u-dev] Request for approval : 8052406: SSLv2Hello
>>> protocol may be filtered out unexpectedly
>>> Date: 	Tue, 30 Sep 2014 19:06:18 +0100
>>> From: 	Rob McKenna <rob.mckenna at oracle.com>
>>> To: 	jdk7u-dev at openjdk.java.net
>>>
>>>
>>>
>>> Approved.
>>>
>>>     -Rob
>>>
>>> On 30/09/14 18:46, Seán Coffey wrote:
>>> > Looking to backport this change from JDK 8u. JDK 8u changeset applies 
>>> > cleanly.
>>> >
>>> > bug report : https://bugs.openjdk.java.net/browse/JDK-8052406
>>> > changeset : http://hg.openjdk.java.net/jdk8u/jdk8u/jdk/rev/ddba61b06470
>>> >
>>> > regards,
>>> > Sean.
>>> >
>>>
>>>
>>>
>>
> 



More information about the security-dev mailing list