Please review CR 8049429 tests for java client server communications with various TLS/SSL combinations.

raghu k.nair raghu.k.nair at oracle.com
Tue Sep 2 01:14:57 UTC 2014


Hi Xuelie,
  Could you please  review the updated code. I have removed the 
dependency on binary files.
http://cr.openjdk.java.net/~tyan/raghu/8049429/webrev02/ 
<http://cr.openjdk.java.net/%7Etyan/raghu/8049429/webrev02/>

Thanks,
Raghu Nair
On 8/28/2014 11:20 AM, Xuelei Fan wrote:
> Remove Drew from the CC list.
>
> I have not read too much about the test code.  I think, binary files are
> not preferred in mercurial workspace.  Would you mind convert the PKCS12
> binary file to nested stream in the test code?
>
> Here is an example about how to avoid the use of binary key store file.
>      test/javax/net/ssl/TLSv12/ShortRSAKey512.java
>
> Xuelei
>
> On 8/28/2014 1:27 PM, raghu k.nair wrote:
>> Hi Andrew,
>>
>>     Could you please help in me in reviewing the following tests.
>>
>> Thanks,
>> Raghu Nair
>>
>> On 8/22/2014 2:58 PM, raghu k.nair wrote:
>>> Hello,
>>>
>>>      Please help to review the tests for java client server
>>> communications with various TLS/SSL combinations.
>>>
>>> Bug -   https://bugs.openjdk.java.net/browse/JDK-8049429
>>> webrev-  http://cr.openjdk.java.net/~tyan/raghu/8049429/webrev01/
>>> <http://cr.openjdk.java.net/%7Etyan/raghu/8049429/webrev01/>
>>>
>>> Thanks
>>> Raghu Nair

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20140902/3ba85291/attachment.htm>


More information about the security-dev mailing list