RFR (XS) : 8057076 : Correct exception message in CertAndKeyGen.java

Sean Mullan sean.mullan at oracle.com
Tue Sep 2 18:56:34 UTC 2014


Looks good.

--Sean

On 09/02/2014 02:47 PM, Seán Coffey wrote:
> https://bugs.openjdk.java.net/browse/JDK-8057076
>
> As per earlier discussion today, a simple update to the exception
> message used in JDK 9.
>
> diff --git
> a/src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java
> b/src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java
> ---
> a/src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java
> +++
> b/src/java.base/share/classes/sun/security/tools/keytool/CertAndKeyGen.java
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (c) 1996, 2012, Oracle and/or its affiliates. All rights
> reserved.
> + * Copyright (c) 1996, 2014, Oracle and/or its affiliates. All rights
> reserved.
>    * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>    *
>    * This code is free software; you can redistribute it and/or modify it
> @@ -158,8 +158,8 @@
>           // publicKey's format must be X.509 otherwise
>           // the whole CertGen part of this class is broken.
>           if (!"X.509".equalsIgnoreCase(publicKey.getFormat())) {
> -            throw new IllegalArgumentException("publicKey's is not
> X.509, but "
> -                    + publicKey.getFormat());
> +            throw new IllegalArgumentException("Public key format is "
> +                + publicKey.getFormat() + ", must be X.509");
>           }
>       }
>
> regards,
> Sean.



More information about the security-dev mailing list