RFR: JDK-8058845 : Update JCE environment for build improvements
Bradford Wetmore
bradford.wetmore at oracle.com
Fri Sep 26 03:02:12 UTC 2014
> javax/crypto/JceSecurity.java
> line 79: this could be (PrivilegedExceptionAction<Void>) as the
> return value is ignored
Good catch.
> It may be better to rename URLVerifier to ProviderVerifier as it verifies
> the security provider of the given codebase. URLVerifier might give
> an interpretation of verifying the given URL. Similarly, the
> verifyProviderJar
> method can be renamed to verifyProvider.
Done.
> javax/crypto/URLVerifier.java
> line 117: should it be pae.getCause()?
Yes, that would be a better one.
Thanks for the review.
brad
More information about the security-dev
mailing list