[9] review request for 8133318: Exclude intermittent failing PKCS11 tests on Solaris SPARC 11.1 and earlier

Vincent Ryan vincent.x.ryan at oracle.com
Tue Aug 11 13:14:40 UTC 2015


The process exec for uname is only made when the test is run on Solaris SPARC earlier than 11.2 but I take your point.
I’ll look at caching its value and re-using the util methods.



> On 11 Aug 2015, at 13:28, Sean Mullan <sean.mullan at oracle.com> wrote:
> 
> There are bunch of methods for determining os.version, etc in jdk/testlibrary/Platform that might be better to reuse.
> 
> Did you consider caching the value of "uname -v" so it can be reused by other tests? It seems expensive to exec a process just to get that value every time one of these tests is run.
> 
> --Sean
> 
> On 08/11/2015 07:34 AM, Vincent Ryan wrote:
>> Please review this change to omit several PKCS11 tests from test runs on Solaris SPARC 11.1 and earlier.
>> The tests had been failing intermittently.
>> 
>> Webrev: http://cr.openjdk.java.net/~vinnie/8133318/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8133318
>> 
>> Thanks.
>> 




More information about the security-dev mailing list