[9] code review request for 8130799: KeyStoreSpi.engineProbe does not throw the expected NullPointerException

Vincent Ryan vincent.x.ryan at oracle.com
Wed Aug 19 16:01:11 UTC 2015


Thanks Xuelei, I’ll add that message.

> On 19 Aug 2015, at 16:56, Xuelei Fan <xuelei.fan at oracle.com> wrote:
> 
> Looks fine to me.  Don't you want to add a exception message to indicate
> the input stream is null?
> 
> Xuelei
> 
> On 8/18/2015 7:23 PM, Vincent Ryan wrote:
>> Please review this trivial change to the KeyStoreSpi.engineProbe method
>> so that it matches its specification wrt NPE.
>> Thanks.
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8130799
>> Webrev: http://cr.openjdk.java.net/~vinnie/8130799/webrev.00/
> 




More information about the security-dev mailing list