RfR JDK-8134456 java/lang/SecurityManager/CheckPackageAccess.java failing on several platforms

Pete Brunet peter.brunet at oracle.com
Fri Aug 28 02:12:19 UTC 2015



On 8/27/15 8:37 PM, Sean Mullan wrote:
> Great, go ahead and push the fix.
Is one review (yours) enough?
>
> --Sean
>
> On 8/27/15 7:49 PM, Pete Brunet wrote:
>> JPRT jdk_lang tests ran clean, 7 builds passed, 8 tests passed.
>> http://scaaa637.us.oracle.com//archive/2015/08/2015-08-27-204226.pbrunet.dev
>>
>>
>> command line:
>> jprt submit -stree . -email peter.brunet at oracle.com -c JDK-8134456
>> -buildenv SKIP_BOOT_CYCLE=false -noqa -ot '.*product.*' -onlytests
>> '.*jdk_lang'
>>
>> Pete
>>
>> On 8/27/15 4:59 PM, Pete Brunet wrote:
>>> Hi Sean, I might need to make a change but this is the JTREG output
>>> from
>>> my local run
>>> jtreg -jdk:./build/windows-x86_64-normal-server-release/images/jdk
>>> ./jdk/test/java/lang/SecurityManager/
>>>
>>> Execution successful
>>>
>>> java/lang/SecurityManager/CheckPackageAccess.java: Make sure all
>>> restricted packages listed in the package.access property in the
>>> java.security file are blocked
>>> java/lang/SecurityManager/CheckPackageMatching.java: Check the matching
>>> implemented by SecurityManager.checkPackageAccess
>>> java/lang/SecurityManager/CheckSecurityProvider.java: Consolidate
>>> java.security files into one file with modifications
>>> java/lang/SecurityManager/NoAWT.java: Sanity check that SecurityManager
>>> methods that used to check AWTPermission now check for AllPermission
>>>
>>> so it looks like there are no problems.  What do you think?
>>>
>>> I'll report back once my JPRT run finishes.
>>>
>>> Pete
>>>
>>> On 8/27/15 4:50 PM, Sean Mullan wrote:
>>>> This looks good to me, if the JPRT results are good. However, does
>>>> this also fix the failure in CheckPackageMatching?  I would have
>>>> expected you needed an additional fix - see my subsequent comment:
>>>>
>>>> https://bugs.openjdk.java.net/browse/JDK-8134456?focusedCommentId=13837407&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13837407
>>>>
>>>>
>>>>
>>>> Thanks,
>>>> Sean
>>>>
>>>> On 08/27/2015 05:02 PM, Pete Brunet wrote:
>>>>> Please review a patch for a test change which is needed to fix an
>>>>> issue
>>>>> caused by JDK-8051626.  Tier 1 tests are being impacted.
>>>>>
>>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8134456/webrev.00/
>>>>>
>>>>> Pete
>>>>>
>>



More information about the security-dev mailing list