RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

Sean Mullan sean.mullan at oracle.com
Tue Dec 1 14:34:21 UTC 2015


Looks good, although the location of the new test (test/sun/security) 
doesn't seem right. A new directory named test/conf/security would 
probably make the most sense, but I think putting it in the new 
test/jdk/security directory is also a better option.

--Sean

On 11/25/2015 09:36 PM, Wang Weijun wrote:
>
>> On Nov 25, 2015, at 11:04 PM, Sean Mullan <sean.mullan at oracle.com> wrote:
>>
>> The fix looks fine to me. For testing, can you create a test that uses a custom java.security file with "#ifndef solaris-sparc" in it, and check whether the property is used or not depending on what system is being tested?
>
> The tool is inside another repo. I can still write one though.
>
> Please take a look at the updated webrev:
>
>     http://cr.openjdk.java.net/~weijun/8141690/webrev.01/
>
> I also fixed a bug inside MakeJavaSecurity.java. If package.access or package.definition happens to be the last property, an NPE will be thrown.
>
> Thanks
> Max
>
>>
>> --Sean
>>>>>
>>>>>    http://cr.openjdk.java.net/~weijun/8141690/webrev.00/
>>>>>
>


More information about the security-dev mailing list