Request for review: 8144093: JEP 244/8051498 - TLS Application-Layer Protocol Negotiation Extension

Bradford Wetmore bradford.wetmore at
Tue Dec 1 23:58:01 UTC 2015

>> 298:  This test is not actually calling into checkResult on the server side.  Ooops!  You need to check the output of the wrap() before calling unwrap() as it overwrites the serverResult.  You need to put in a similar checkResult() before doing the flip()s.
> So checks are required before and after the buffer flips, right?

Yes.  In a full handshake, the Handshake complete message could be the 
result of an unwrap (client) or wrap (server).


More information about the security-dev mailing list