Code Review Request 8143298 Test ReadTimeout.java fails intermittently
Xuelei Fan
xuelei.fan at oracle.com
Wed Dec 2 01:12:33 UTC 2015
On 12/2/2015 9:05 AM, Wang Weijun wrote:
> Socket is a Closeable, so you can
>
> try (Socket sock = ....) { ... }
>
Yes. Better coding. Updated in the same webrev.
> If you want more debug messages, why not e.printStackTrace()? Message is enough?
>
I was wondering, the cached connection (which may be closed by server
thread after the client call) may be the cause. Resource cleanup and
message may be enough.
Thanks,
Xuelei
> Thanks
> Max
>
>> On Dec 2, 2015, at 8:55 AM, Xuelei Fan <xuelei.fan at oracle.com> wrote:
>>
>> Hi,
>>
>> Please review the test fix for JDK-8143298:
>>
>> http://cr.openjdk.java.net/~xuelei/8143298/webrev.00/
>>
>> The root cause of the intermittent test failure is still unclear to me.
>> I updated the test with more output messages, and clear the resources
>> in finally blocks. Hope the update can expose the real cause if it
>> fails again in the future.
>>
>> Thanks,
>> Xuelei
>
More information about the security-dev
mailing list