Code Review Request, 8136410 AlgorithmDecomposer is not parsing padding correctly

Amy Lu amy.lu at oracle.com
Mon Dec 7 12:53:18 UTC 2015


On 12/7/15 8:35 PM, Xuelei Fan wrote:
> On 12/7/2015 8:23 PM, Amy Lu wrote:
>> Hi, Xuelei
>>
>> test/sun/security/util/AlgorithmConstraints/Decomposealgorithms.java
>>
>>    line36     private final static String PATH =
>> System.getProperty("test.src", ".");
>>
>> It seems that this line could be removed.
>>
> Oops, bad copy and past.  Updated.
Thank you for the quick update. I'm not openjdk reviewer and will leave 
the review to official reviewers.

Thanks,
Amy
>
> Thanks,
> Xuelei
>
>> Thanks,
>> Amy
>>
>> On 12/7/15 7:08 PM, Xuelei Fan wrote:
>>> Hi Brad,
>>>
>>> Please review this fix for JDK-8136410:
>>>
>>>      http://cr.openjdk.java.net/~xuelei/8136410/webrev.00/
>>>
>>> AlgorithmDecomposer cannot parse "Padding" string properly as 'in' is
>>> used as a String split separator.  "NoPadding" was incorrectly split as
>>> "NoPadd" and "g".
>>>
>>> This update update the slit String split pattern, and "Padding" get
>>> specially handled.
>>>
>>> Thanks,
>>> Xuelei



More information about the security-dev mailing list