Code Review Request, 8141651 Deadlock in sun.security.ssl.SSLSocketImpl

Sean Mullan sean.mullan at oracle.com
Wed Dec 9 19:40:21 UTC 2015


Fix looks good, interesting issue, though I wonder if there is a better 
locking scheme, but probably a question for another time.

--Sean

On 12/05/2015 07:03 PM, Xuelei Fan wrote:
> Hi,
>
> Please review the fix for JDK-8141651:
>
>      http://cr.openjdk.java.net/~xuelei/8141651/webrev.00/
>
> In JDK 9, there is a deadlock introduced.  One thread can lock
> SSLSocketImpl instance, and try to lock SSLSocketImpl.writeLock; Another
> thread may lock SSLSocketImpl.writeLock, and then try to lock
> SSLSocketImpl instance.  A deadlock happens.
>
> This fix is trying to remove the latter lock sequence.
>
> No new regression test as it is hard to re-produce the issue.
>
> Thanks,
> Xuelei
>


More information about the security-dev mailing list