RFR: Remove @Deprecated annotation from java.security.acl and javax.security.cert packages

Mandy Chung mandy.chung at oracle.com
Thu Dec 10 22:12:52 UTC 2015



On 12/10/2015 01:18 PM, Sean Mullan wrote:
> On 12/10/2015 01:14 PM, Mandy Chung wrote:
>>
>>> On Dec 10, 2015, at 7:53 AM, Sean Mullan <sean.mullan at oracle.com>
>>> wrote:
>>>
>>> Max asked me to add the com.sun.jarsigner package to this bug,
>>> which also has an unnecessary @Deprecated annotation. I also made a
>>> few tweaks to the deprecation wording here and there, so a webrev
>>> is probably easier to review than diffs now:
>>>
>>> http://cr.openjdk.java.net/~mullan/webrevs/8144784/webrev.00/
>>
>> Is there any other package-info.java beside these three packages?  It
>> worths to have a quick scan on the source.
>>
>> To me, it’s fine to keep the existing @deprecated comment in
>> com.sun.jarsigner.* classes since I assume you want to discourage new
>> classes to be added in that package.
>
> Well, we are trying to "deprecate" use of the @Deprecated annotation 
> on packages, so I would prefer not to leave this in (also, I heard 
> there will eventually be a javac warning for this). Instead I will add 
> a sentence or comment that says new classes should not be added to the 
> package. Is that ok?

To clarify: I meant the original comment in these two files seems fine 
and cound be reverted:
src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSigner.java
src/jdk.jartool/share/classes/com/sun/jarsigner/ContentSignerParameter.java

Your suggestion to add a sentence in package-info.java is a fine idea.

Mandy



More information about the security-dev mailing list