RFR: 8065553: Failed Java web start via IPv6 (Java7u71 or later)

Rob McKenna rob.mckenna at oracle.com
Tue Feb 10 02:30:00 UTC 2015


Thanks Xuelei, will do.

     -Rob

On 10/02/15 01:59, Xuelei Fan wrote:
> Hi Rob,
>
> Sorry, I missed this review request.  The change looks fine to me,
> except a minor coding style comment.
>
>   159            InetAddress.getByName(ipAddress)))
>   160       {
>
> Would you mind join two lines together?  We normally don't use single
> line "{"".
>
> - 159            InetAddress.getByName(ipAddress)))
> - 160       {
> + 159            InetAddress.getByName(ipAddress))) {
>
> Please add a "noreg-" tag if no plan to add a new regression test.
>
> Thanks,
> Xuelei
>
> On 1/29/2015 12:10 AM, Rob McKenna wrote:
>> Hi folks,
>>
>> There is a problem in sun/security/util/HostnameChecker.java matchIP
>> method. When comparing an ipv6 address with its abbreviated counterpart
>> the comparison will fail. I'm open to a more efficient way of comparing
>> these addresses (perhaps a utility method to abbreviate an ipv6 string)
>> but this seems to do the job.
>>
>> http://cr.openjdk.java.net/~robm/8065553/webrev.01/
>>
>> (btw, though this is a security component, it does seem to have a strong
>> networking slant, so feel free to redirect me to net-dev)
>>
>>      -Rob
>>
>>
>>



More information about the security-dev mailing list