RFR: 8073108: GHASH Intrinsics

David Holmes david.holmes at oracle.com
Tue Feb 17 01:23:57 UTC 2015


Hi Tony,

Not a review as hotspot compiler folk need to review this.

On 17/02/2015 7:11 AM, Anthony Scarpino wrote:
> Hi,
>
> I'm requesting a code review to intrinsify the GHASH operations for both
> x86 and SPARC platforms.  This greatly increases performance over
> software for AES/GCM crypto operations, details are in the bug.

This may be normal for intrinsics but there seems to be a large amount 
of shared code being updated to support these platform specific 
enhancements. What happens on other platforms if the user sets 
UseGHASHIntrinsics? Shouldn't there be a guard against this in 
arguments.cpp?

Thanks,
David

> The review is for two repos, hotspot and jdk:
>
> http://cr.openjdk.java.net/~ascarpino/8073108/hotspot/webrev/
>
> http://cr.openjdk.java.net/~ascarpino/8073108/jdk/webrev/
>
> thanks
>
> Tony


More information about the security-dev mailing list