RFR: 8073108: GHASH Intrinsics

Anthony Scarpino anthony.scarpino at oracle.com
Tue Feb 17 19:59:08 UTC 2015


On 02/17/2015 12:57 AM, Florian Weimer wrote:
> On 02/16/2015 10:11 PM, Anthony Scarpino wrote:
>> http://cr.openjdk.java.net/~ascarpino/8073108/jdk/webrev/
>
> I think the “state” field in GHASH should be final.  Is C2 able to
> eliminate the array bounds checks?  (Although it's not in the inner loop
> and thus probably not relevant for performance.)

I'm not sure want you asking about in regard to the bounds checking? 
Are you asking about checking the bounds of "state"?

>
> The comment on processBlock(byte[], int, int) is confusing.  I don't
> understand what it is trying to say.

That is why I can never proofread my own writing. :)
I'll fix that up.. What means to say is the method arguments list and 
method name cannot be changed, along with some operations inside the 
method cannot occur or it can break intrinsics.


More information about the security-dev mailing list