RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

Chris Hegarty chris.hegarty at oracle.com
Thu Jan 1 19:56:08 UTC 2015


This looks very nice Peter.

Just a small comment on the test; it may avoid future problems if the test use deleteFileWithRetry, from the test library [1], rather than file.delete().

-Chris.

[1] http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/lib/testlibrary/jdk/testlibrary/FileUtils.java

On 1 Jan 2015, at 19:21, Peter Levart <peter.levart at gmail.com> wrote:

> 
> On 12/29/2014 04:51 PM, Alan Bateman wrote:
>> On 29/12/2014 09:45, Peter Levart wrote: 
>>> 
>>> Thanks for looking at this, Alan. 
>>> 
>>> You're right about File.getCanonicalFile(). It already checks read permission for a file. The additional explicit check is superfluous. I have removed it. 
>>> 
>>> With explicit check I wanted the API to behave uniformly regardless of whether the returned stream is opened by getInputStream() call or an already opened stream is just returned. getCannonicalFile() already takes care of it. Here's the updated webrev: 
>>> 
>>> http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.03/ 
>> Updated patch looks good to me. 
>> 
>> -Alan. 
> 
> Thanks, Alan.
> 
> Peter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20150101/138a4c51/attachment.html>


More information about the security-dev mailing list