[JDK-9] RFR: 8048607: Implement key generation tests

zaiyao liu zaiyao.liu at oracle.com
Wed Jan 7 02:54:12 UTC 2015


Hi Xuelei,

Thanks for review, please check the update: 
http://cr.openjdk.java.net/~zailiu/8044193/webrev.03/

Please help to push it if OK.
Full comments:
8048607: Implement key generation tests
Reviewed-by: xuelei
Contributed-by: Zaiyao Liu <zaiyao.liu at oracle.com>

Thanks and Regards.

Kevin
在 2015/1/7 8:38, Xuelei Fan 写道:
> Sorry for the delay.
>
> TestKGParity.java
> -----------------
> Can you provide more comment on what kind of algorithms are you want to
> cover in this testing?
>
> Suggested to use the bug synopsis as the summary filed.
>
> You are the author of this test.  You may want to remove the author line
> in the class comment.
>
> Otherwise, looks fine to me.
>
> Thanks,
> Xuelei
>
>
> On 9/9/2014 10:47 AM, zaiyao liu wrote:
>> Hi Xuelei,
>>
>> Can you help to review this test?
>> JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048607
>> Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048607/webrev01/
>>
>> Thanks
>>
>> Kevin
>> 于 2014/8/22 16:05, zaiyao liu 写道:
>>> May I request you to review 1 new test to be added for key generation algorithms. New test are added to address following:
>>> - Generate a secret key using key generator for specified algorithm,
>>> retrieve its value, then verify the parity of that key.
>>>
>>> JDK Issue: https://bugs.openjdk.java.net/browse/JDK-8048607
>>> Webrev: http://cr.openjdk.java.net/~tyan/kevin/JDK-8048607/webrev01/
>>>
>>> Thanks,
>>>      
>>> Kevin



More information about the security-dev mailing list