Review request for CR 8044193 Need to add known answer tests for AES cipher

[Valerie Peng]

Hi, Kevin,

Somehow I missed your Dec email, sorry for the late reply...

I should probably clarify my earlier comments about test policies.
1) are u sure the testAESWithDefaultProvider.policy is necessary? I 
didn't find any add/remove provider calls in 
TestAESWithDefaultProviders.java?
2)The RuntimePermission fo "loadLibrary.sunec" in the 
testAESWithRemoveAddProvider.policy should not be needed. It could be 
due to an earlier bug which has been fixed. Can you please re-run the 
test without this permission and see if it's still necessary to have 
this granted?
3) The 3 test policies even though for different tests, if they have the 
same content, perhaps we can consolidate them into just 1.

Thanks,
Valerie

On 1/6/2015 3:39 PM, Rajan Halade wrote:
> Subject: 	Re: Review request for CR 8044193 Need to add known answer 
> tests for AES cipher
> Date: 	Mon, 22 Dec 2014 11:11:38 +0800
> From: 	zaiyao liu <zaiyao.liu at oracle.com>
> Organization: 	Oracle Corporation
> To: 	security-dev at openjdk.java.net
>
>
>
> Hi Valeries,
>
> Thanks for review, please check the update:
> http://cr.openjdk.java.net/~rhalade/8044193/webrev.02/
>
> Regards.
>
> Kevin
> 在 2014/8/6 3:00, Valerie Peng 写道:
> >
> >  The tests look fine.
> >  However, can you please update the test policy files with fine-grained
> >  permissions for SunJCE provider?
> >  Please refer to the current<jre>/lib/security/java.policy.
> >
> >  Thanks,
> >  Valerie
> >
> >  On 7/28/2014 9:36 PM, zaiyao liu wrote:
> >>  Hello,
> >>      Please help to review the tests for AES cipher.
> >>      This tests test AES ciphers with different modes and padding
> >>  schemes when provider change,are part of tests for bug 8044193(Open
> >>  part)
> >>  Bug -https://bugs.openjdk.java.net/browse/JDK-8044193
> >>  webrev-http://cr.openjdk.java.net/~rhalade/8044193/webrev.00/
> >>
> >>  Thanks
> >>
> >>  Kevin Liu
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20150112/96f0b416/attachment.htm>