[9] request for review: 8049171: Additional tests for jarsigner's warnings

Artem Smotrakov artem.smotrakov at oracle.com
Mon Jan 26 08:24:31 UTC 2015


On 01/26/2015 11:11 AM, Wang Weijun wrote:
> JarUtils:
>
> You can break after line 83.
Sure, I have updated the webrev

http://cr.openjdk.java.net/~asmotrak/8049171/webrev.03/
>
> Otherwise very good.
Thanks for reviewing this.
>
> Thanks
> Max
>
>> On Jan 26, 2015, at 15:55, Artem Smotrakov <artem.smotrakov at oracle.com> wrote:
>>
>> Hi Max,
>>
>> Here is an updated webrev, please take a look.
>>
>> http://cr.openjdk.java.net/~asmotrak/8049171/webrev.02/
>>
>> Artem
>>
>> On 01/26/2015 05:03 AM, Weijun Wang wrote:
>>>
>>> On 1/23/2015 16:12, Artem Smotrakov wrote:
>>>> If the MANIFEST and the signature files must be at the beginning, should
>>>> it be considered as a bug in jarsigner? Should it reject such files?
>>> I think so. Will file a bug.
>>>
>>>>> The "jar u" way is to copy each old entry into destination unless the
>>>>> entry name is in the updated list where the new file will be read.
>>>>> Finally the untouched files in the updated list are appended.
>>>> Since tests were not originally for checking some unusual ways for
>>>> updating jars, I think they need to be updated to use the "jar u" way
>>>> for adding unsigned entry.
>>> Good.
>>>
>>> Thanks
>>> Max
>>>
>>>> Artem
>>>>
>>>>



More information about the security-dev mailing list