RFR 8130022: Use Java-style array declarations consistently

Seán Coffey sean.coffey at oracle.com
Wed Jul 8 18:03:42 UTC 2015


On 08/07/2015 18:14, Ivan Gerasimov wrote:
>
>
> On 08.07.2015 18:57, Seán Coffey wrote:
>> Looks good to me.. and is much easier to read now!
>>
> Thanks Seán for review!
>
> I've missed some portion of update int the previous webrev.
> Now, sending the whole changeset: 
> http://cr.openjdk.java.net/~igerasim/8130022/01/webrev/
>
> Would you please take another look at your convenience?
Still looks good.

regards,
Sean.

> I'll fire a jprt job before pushing to make sure nothing is broken.
>
> Sincerely yours,
> Ivan
>
>> Regards,
>> Sean.
>>
>> On 08/07/2015 16:35, Ivan Gerasimov wrote:
>>> Hello!
>>>
>>> We've got a request to fix javadoc for SecureRandom, so that the 
>>> example code will read
>>> byte[] bytes = new byte[20];
>>> instead of
>>> byte bytes[] = new byte[20];
>>>
>>> I took opportunity to make all array declarations throughout 
>>> security-lib source code more of Java-style.
>>>
>>> Would you please help review this cleanup?
>>>
>>> BUGURL: https://bugs.openjdk.java.net/browse/JDK-8130022
>>> WEBREV: http://cr.openjdk.java.net/~igerasim/8130022/00/webrev/
>>>
>>> Sincerely yours,
>>> Ivan
>>
>>
>>
>



More information about the security-dev mailing list