[9] code review request for 8130850: Support loading a keystore with a custom KeyStore.LoadStoreParameter class
Sean Mullan
sean.mullan at oracle.com
Thu Jul 9 20:45:58 UTC 2015
The specification for KeyStoreSpi.engineLoad is completely silent on
what the default implementation does. We really should add something
here, so providers know if they need to override it or if the default
impl. is sufficient. Could you add an @implSpec section describing what
it does? (you will need a CCC).
Otherwise, looks fine.
--Sean
On 07/09/2015 09:30 AM, Vincent Ryan wrote:
> Please review this change to the implementation of the KeyStoreSpi.engineLoad method to accept custom KeyStore.LoadStoreParameter classes.
> Thanks.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8130850
> Webrev: http://cr.openjdk.java.net/~vinnie/8130850/webrev.00/
>
More information about the security-dev
mailing list