[9] RFR: 8049814: Additional SASL client-server tests

Artem Smotrakov artem.smotrakov at oracle.com
Wed Jul 15 02:29:13 UTC 2015


Hi Max,

Status is currently used to indicate an error on server side, or that 
server is complete. A client sends only CONTINUE status. I can update it 
to send null if CONTINUE is confusing.

Addressed other comments:

http://cr.openjdk.java.net/~asmotrak/8049814/webrev.02/

Artem

On 07/12/2015 06:47 PM, Weijun Wang wrote:
> One major question:
>
> Is it necessary for one side to send both the status and the data to 
> its peer? Your server side does not read the status but the client 
> uses it.
>
> And some style things:
>
> 81-86: "new String[] { QOP_AUTH }" is defined as authQop on line 90. 
> Why not move lines 88-93 to the beginning?
>
> 92: s/authQopConf/authConfQop/;
>
> Thanks
> Max
>
> On 07/10/2015 01:16 AM, Artem Smotrakov wrote:
>> Removed one duplicate test case at line 100 in webrev.00, please see
>> updated webrev:
>>
>> http://cr.openjdk.java.net/~asmotrak/8049814/webrev.01/
>>
>> Artem
>>
>> On 07/08/2015 05:30 PM, Artem Smotrakov wrote:
>>> Hello,
>>>
>>> Please review a client/server test for SASL which uses different
>>> mechanisms and QOPs.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8049814
>>> Webrev: http://cr.openjdk.java.net/~asmotrak/8049814/webrev.00/
>>>
>>> Artem
>>



More information about the security-dev mailing list