[9] Review request for 8085979: Make some DTLS feature functional tests work also for TLS protocol
Xuelei Fan
xuelei.fan at oracle.com
Tue Jun 9 15:47:46 UTC 2015
On 6/9/2015 11:31 PM, Konstantin Shefov wrote:
> Xuelei, thanks for reviewing
>
> typo is corrected:
> http://cr.openjdk.java.net/~kshefov/8085979/webrev.01/
>
Why there are old "UnSupportedCiphersTest.java" files? If you have not
committed the changeset, you can "hg forget" to undo a previous "hg
add". As would avoid the unnecessary old file logs.
Xuelei
> -Konstantin
>
> On 06/09/2015 06:07 PM, Xuelei Fan wrote:
>> On 6/9/2015 10:57 PM, Xuelei Fan wrote:
>>> Looks fine to me. Nice port to TLS protocols.
>>>
>>> A very minior comment about the class name.
>>> TLSUnSupportedCiphersTest.java:
>>> replease "UnSupported" with "Unsupported".
>>>
>> typo: replace "UnSupported" with "Unsupported".
>>
>>> Thanks,
>>> Xuelei
>>>
>>> On 6/8/2015 11:04 PM, Konstantin Shefov wrote:
>>>> Hello,
>>>>
>>>> Please review distribution of some DTLS feature tests to TLS protocol.
>>>> Some DTLS tests may also be used to test the same functionality in TLS
>>>> protocol and its versions.
>>>> It is test only improvement.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8085979
>>>> webrev: http://cr.openjdk.java.net/~kshefov/8085979/webrev.00/
>>>>
>>>>
>>>> Thanks
>>>> -Konstantin
>
More information about the security-dev
mailing list