RFR: 8073108: GHASH Intrinsics [need second reviewer]

John Rose john.r.rose at oracle.com
Wed Jun 17 23:06:40 UTC 2015


Thumbs up.   Thanks!  — John

On Jun 17, 2015, at 3:31 PM, Anthony Scarpino <anthony.scarpino at oracle.com> wrote:
> 
> On 06/15/2015 05:20 PM, John Rose wrote:
>> Thanks for taking this on.
>> 
>> It looks good, except for one thing.  The intrinsic does not need to
>> be an instance method, and doing so creates an undesirable coupling
>> between the JVM and JDK.  Specifically, the JDK should not need to
>> know about subkeyH and state fields.  The Java code should pass those
>> as plain (array long[2]) arguments to the intrinsic method
>> processBlocks, which should be adjusted to be static.  The domain
>> check routine should be adjusted to be static also.
>> 
> 
> Hi John,
> 
> the updated webrevs are at:
> http://cr.openjdk.java.net/~ascarpino/8073108/hotspot/webrev.04/
> http://cr.openjdk.java.net/~ascarpino/8073108/jdk/webrev.04/
> 
> thanks
> 
> Tony
> 



More information about the security-dev mailing list