RFR 8023546: sun/security/mscapi/ShortRSAKey1024.sh fails intermittently
Sean Mullan
sean.mullan at oracle.com
Wed Jun 24 15:26:24 UTC 2015
Also, https://bugs.openjdk.java.net/browse/JDK-8025202 might be a
duplicate. The symptoms look similar.
--Sean
On 06/23/2015 04:05 AM, Vincent Ryan wrote:
> Your fix looks good. Thanks Max.
>
>> On 23 Jun 2015, at 07:34, Weijun Wang <weijun.wang at oracle.com> wrote:
>>
>> Hi Michael
>>
>> Webrev updated at
>>
>> http://cr.openjdk.java.net/~weijun/8023546/webrev.01
>>
>> I added a check about the extra sign byte, I even added a null check in KeyStore.java, although if the fix is done right they should never happen.
>>
>> The return value of the convertToLittleEndian() function is now always destinationLength. This was also the value before the fix, which is the number of bytes we actually write, including zeroes.
>>
>> Personally I'm still a little afraid of --x (and x++, if it's used in an expression), so I kept the old style.
>>
>> Can anyone with a reviewer badge also look at this?
>>
>> Thanks
>> Max
>>
>
More information about the security-dev
mailing list