<Security Dev> [9] Review Request: 8028266 Tidy warnings cleanup for packages java.security/javax.security

[alexander stepanov]

Hello Bradford,

I have finally to fix tidy warnings for java.security, javax.security, 
javax.crypto and javax.net packages (sorry for repeated request).

Could you please review the webrev updated?
http://cr.openjdk.java.net/~avstepan/8028266/webrev.02/

It was re-generated because of changes in JDK code layout and contains 
fixes for JDK-8040260, JDK-8028266.

Could please anyone from JCE team suggest what should be done for the 
next step if the fixes are satisfactory?

Thanks,
Alexander


On 22.04.2014 16:41, alexander stepanov wrote:
> Hello Bradford,
>
> Thanks,
>
> Could you please review again:
> http://cr.openjdk.java.net/~yan/JDK-8028266/webrev.01/
>
> > Who is going to help you with that?
> I didn't communicate with JCE team before. So could you please appoint 
> me someone to contact? Thanks.
>
> Regards,
> Alexander
>
>
> On 22.04.2014 1:08, Bradford Wetmore wrote:
>> We usually update the copyright dates:
>>
>> * Copyright (c) 1997, 2014, Oracle and/or its affiliates. All rights 
>> reserved.
>>
>> javax/security/auth/kerberos/package-info.java
>> ==============================================
>>
>> "yes", or "no", case-insensitive.
>> ->
>> "yes", or "no", and values are case-insensitive.
>>
>> I noticed in several places that while your changes are ok, it 
>> doesn't update the <i>value</i> instead of switching to {@code value}.
>>
>> In a previous webrev, I mentioned that you'll need to work with 
>> someone to update the built JCE binaries for the javax.crypto 
>> changes.  Who is going to help you with that?
>>
>> Brad
>>
>>
>>
>> On 4/21/2014 3:11 AM, alexander stepanov wrote:
>>> Hello,
>>>
>>> Could you please review the fix for the following bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8028266
>>>
>>> Webrev corresponding:
>>> http://cr.openjdk.java.net/~yan/JDK-8028266/webrev.00/
>>>
>>> Just a minor cleanup of javadoc to avoid tidy warnings; no other code
>>> affected.
>>>
>>> Thanks.
>>>
>>> Regards,
>>> Alexander
>