[9] RFR: 7145757: CertificateExtensions uses non-consistent key names

Wang Weijun weijun.wang at oracle.com
Wed Mar 18 23:09:08 UTC 2015


Hi Jason

I was thinking about changing all set/get calls to using OID so inside CertificateExtensions and CRLExtensions you won't need to care about name conversions. Is that possible?

Also I see you adding some IOException throwing and catching. Is there any case you actually see them? I would think if that really happen there might be some programming error.

--Max

> On Mar 18, 2015, at 09:34, Jason Uh <jason.uh at oracle.com> wrote:
> 
> Please review this fix, which changes the internal map in sun.security.x509.CertificateExtensions and CRLExtensions to always use the OID as the key.
> 
> As stated in the JBS issue:
>> The sun.security.x509.CertificateExtensions class maintains a Map<String,Extension> map field to store all the extensions it manages. The key of map uses the name (say, "BasicConstraints") of the extension, or the OID when the type of the extension is unknown.
> 
> With this change, the map will consistently use the OID as the key.
> 
> webrev: http://cr.openjdk.java.net/~juh/7145757/00/
> bug: https://bugs.openjdk.java.net/browse/JDK-7145757
> 
> Thanks,
> Jason




More information about the security-dev mailing list