RFR 8047789: auth.login.LoginContext needs to be updated to work with modules

Mandy Chung mandy.chung at oracle.com
Fri Mar 20 20:12:39 UTC 2015


On 3/20/15 7:39 AM, Wang Weijun wrote:
> Please review the code changes at
>
>     http://cr.openjdk.java.net/~weijun/8047789/webrev.03/

It looks okay to me.  Removing some use of reflection seems
a good thing.

One observation: invoke(String methodName) now calls the method
statically and the implementation has conditional code depending
on which of the four methods.  It seems that you could do some
refactoring to define 4 different methods for example:

  571        invokePriv(LOGIN_METHOD) -> invokeLoginMethod

This is an separate issue.  Just to mention for future cleanup
to consider.

Mandy

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/security-dev/attachments/20150320/82e2e808/attachment.html>


More information about the security-dev mailing list